Check SoftDeletes on HasOne or BelongsTo relations #1628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yajra
previously requested changes
Mar 11, 2018
| * @param string $type | ||
| */ | ||
| protected function performJoin($table, $foreign, $other, $type = 'left') | ||
| protected function performJoin($table, $foreign, $other, $deletedAt = false, $type = 'left') |
There was a problem hiding this comment.
Please put deletedAt as the last argument to prevent possible breaking change.
| protected function checkSoftDeletesOnModel($model) | ||
| { | ||
| if (in_array('Illuminate\Database\Eloquent\SoftDeletes', class_uses($model))) { | ||
| return $model->getDeletedAtColumn(); |
There was a problem hiding this comment.
Does this return the fully qualified column name? Can't check the codes yet but PR looks good. Thanks!
|
Sorry for late reply. The PR looks good. Will try to test this on actual project next week and possibly add a test case for this scenario. |
|
Released on v8.4.2, thanks a lot! 🥂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, if the related table uses SoftDeletes, it is not handled via the
performJoinmethod.